Skip to content

Wallet Group Resetting Exploration #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Wallet Group Resetting Exploration #2240

wants to merge 8 commits into from

Conversation

Blazebrain
Copy link
Contributor

This change:

  • Tentatively fixes the issue with the wallet groups bug, where some wallets are wrongly grouped.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@Blazebrain Blazebrain self-assigned this Apr 30, 2025
@Blazebrain Blazebrain requested a review from OmarHatem28 April 30, 2025 08:33
@Blazebrain Blazebrain marked this pull request as draft April 30, 2025 08:34
@Blazebrain Blazebrain changed the title fix(generic-fixes): Fixes to a couple of raised issues. Wallet Group Resetting Exploration May 29, 2025
Blazebrain and others added 8 commits June 3, 2025 09:04
This change:
- Tentatively fixes the issue with the wallet groups bug, where some wallets are wrongly grouped.
- Exploratory route to getting more information on the cause of the wallet grouping bug.
- Introduces a dev hash change log page that gives information on the changes that occurs on the hashWalletIdentifier and where the change gets triggered.
Add ability to export hash change logs
background sync didn't work reliably with `android:debuggable`.
AOSP `su` binary also behaved weirdly, and didn't want
to work properly, so I've opted into using MagiskSU - which
also didn't work reliably but it's much better than alternatives
(and is somewhat standard).

lsof will fallback to using `su` when output without it is empty
usually when app lacks `android:debuggable`, this change
makes checking which PID hold access to files during initializeAppConfigs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants